Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DG-1875 setClassification.deleteClassification optimisation fix #3666

Merged
merged 2 commits into from
Oct 27, 2024
Merged

Conversation

hr2904
Copy link
Collaborator

@hr2904 hr2904 commented Oct 27, 2024

Change description

in setClassification.deleteClassification flow, taskManagement.getInProgressTasks() is fetching tasks from gremlin query, which is inherently slow on large-dataset tenants. Instead of doing a gremlin query to fetch in-progress tasks, added an ES-fetching mechanism.

Alternative to current implementations which failed

Alternative was that, we simply remove the getInProgressTasks() check so that deleteClassification can detach and create deleteTasks while ADD-PROPAGATION was running. It provided an IllegalStateException issue [see below]
image
Along with causing inconsistencies [see below]
image
This is while the delete-propagation task found nothing to remove.^

Current implementation proof

image
image
image

Type of change

  • Bug fix (fixes an issue)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@hr2904 hr2904 merged commit 89a73b6 into beta Oct 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant